fix autolink when code is not enabled for editor #4344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdbch
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Good find. I moved the base branch to main so we can include this as a hotfix instead of going the whole rc => release round.
@svenadlung I'd merge this asap so we don't have broken editors
kodiakhq bot
referenced
this pull request
in weareinreach/TransMascFutures
Aug 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@tiptap/extension-link](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2fextension-link/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tiptap/react](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2freact/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tiptap/starter-kit](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2fstarter-kit/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ueberdosis/tiptap (@​tiptap/extension-link)</summary> ### [`v2.1.3`](https://togithub.com/ueberdosis/tiptap/releases/tag/v2.1.3) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/v2.1.2...v2.1.3) ##### What's Changed - fix autolink when code is not enabled for editor by [@​steven-qi](https://togithub.com/steven-qi) in [https://github.com/ueberdosis/tiptap/pull/4344](https://togithub.com/ueberdosis/tiptap/pull/4344) ##### New Contributors - [@​steven-qi](https://togithub.com/steven-qi) made their first contribution in [https://github.com/ueberdosis/tiptap/pull/4344](https://togithub.com/ueberdosis/tiptap/pull/4344) **Full Changelog**: ueberdosis/tiptap@v2.1.2...v2.1.3 ### [`v2.1.2`](https://togithub.com/ueberdosis/tiptap/blob/HEAD/packages/extension-link/CHANGELOG.md#212-2023-08-17) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/v2.1.1...v2.1.2) **Note:** Version bump only for package [@​tiptap/extension-link](https://togithub.com/tiptap/extension-link) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/GLAAD). PR-URL: #144 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
kodiakhq bot
referenced
this pull request
in weareinreach/InReach
Aug 18, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@iconify/utils](https://iconify.design/docs/libraries/utils/) ([source](https://togithub.com/iconify/iconify)) | [`2.1.7` -> `2.1.8`](https://renovatebot.com/diffs/npm/@iconify%2futils/2.1.7/2.1.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@playwright/test](https://playwright.dev) ([source](https://togithub.com/Microsoft/playwright)) | [`1.37.0` -> `1.37.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.37.0/1.37.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-a11y](https://togithub.com/storybookjs/storybook/tree/next/code/addons/a11y) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-a11y/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-actions](https://togithub.com/storybookjs/storybook/tree/next/code/addons/actions) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-actions/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-docs](https://togithub.com/storybookjs/storybook/tree/next/code/addons/docs) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-docs/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-essentials](https://togithub.com/storybookjs/storybook/tree/next/code/addons/essentials) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-essentials/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-interactions](https://togithub.com/storybookjs/storybook/tree/next/code/addons/interactions) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-interactions/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-links](https://togithub.com/storybookjs/storybook/tree/next/code/addons/links) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-links/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-viewport](https://togithub.com/storybookjs/storybook/tree/next/code/addons/viewport) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2faddon-viewport/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/components](https://togithub.com/storybookjs/storybook/tree/next/code/ui/components) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2fcomponents/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/core-events](https://togithub.com/storybookjs/storybook/tree/next/code/lib/core-events) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2fcore-events/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/jest](https://togithub.com/storybookjs/jest) | [`0.2.0` -> `0.2.1`](https://renovatebot.com/diffs/npm/@storybook%2fjest/0.2.0/0.2.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/manager-api](https://togithub.com/storybookjs/storybook/tree/next/code/lib/manager-api) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2fmanager-api/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/nextjs](https://togithub.com/storybookjs/storybook/tree/next/code/frameworks/nextjs) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2fnextjs/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/preview-api](https://togithub.com/storybookjs/storybook/tree/next/code/lib/preview-api) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2fpreview-api/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react](https://togithub.com/storybookjs/storybook/tree/next/code/renderers/react) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2freact/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/theming](https://togithub.com/storybookjs/storybook/tree/next/code/lib/theming) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2ftheming/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/types](https://togithub.com/storybookjs/storybook/tree/next/code/lib/types) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/@storybook%2ftypes/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@t3-oss/env-nextjs](https://togithub.com/t3-oss/t3-env) | [`0.6.0` -> `0.6.1`](https://renovatebot.com/diffs/npm/@t3-oss%2fenv-nextjs/0.6.0/0.6.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tiptap/extension-link](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2fextension-link/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tiptap/react](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2freact/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@tiptap/starter-kit](https://tiptap.dev) ([source](https://togithub.com/ueberdosis/tiptap)) | [`2.1.1` -> `2.1.3`](https://renovatebot.com/diffs/npm/@tiptap%2fstarter-kit/2.1.1/2.1.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [mantine-react-table](https://www.mantine-react-table.com/) ([source](https://togithub.com/KevinVandy/mantine-react-table)) | [`1.1.1` -> `1.1.2`](https://renovatebot.com/diffs/npm/mantine-react-table/1.1.1/1.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [react-phone-number-input](https://gitlab.com/catamphetamine/react-phone-number-input) | [`3.3.2` -> `3.3.4`](https://renovatebot.com/diffs/npm/react-phone-number-input/3.3.2/3.3.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [storybook](https://togithub.com/storybookjs/storybook/tree/next/code/lib/cli) ([source](https://togithub.com/storybookjs/storybook)) | [`7.3.1` -> `7.3.2`](https://renovatebot.com/diffs/npm/storybook/7.3.1/7.3.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Microsoft/playwright (@​playwright/test)</summary> ### [`v1.37.1`](https://togithub.com/microsoft/playwright/releases/tag/v1.37.1) [Compare Source](https://togithub.com/Microsoft/playwright/compare/v1.37.0...v1.37.1) ##### Highlights [https://github.com/microsoft/playwright/issues/26496](https://togithub.com/microsoft/playwright/issues/26496) - \[REGRESSION] webServer stdout is always getting printed[https://github.com/microsoft/playwright/issues/26492](https://togithub.com/microsoft/playwright/issues/26492)2 - \[REGRESSION] test.only with project dependency is not working #### Browser Versions - Chromium 116.0.5845.82 - Mozilla Firefox 115.0 - WebKit 17.0 This version was also tested against the following stable channels: - Google Chrome 115 - Microsoft Edge 115 </details> <details> <summary>storybookjs/storybook (@​storybook/addon-a11y)</summary> ### [`v7.3.2`](https://togithub.com/storybookjs/storybook/blob/HEAD/CHANGELOG.md#732) [Compare Source](https://togithub.com/storybookjs/storybook/compare/v7.3.1...v7.3.2) - Maintenance: Revert "WebpackBuilder: Remove need for `react` as peerDependency" - [#​23882](https://togithub.com/storybookjs/storybook/pull/23882), thanks [@​vanessayuenn](https://togithub.com/vanessayuenn)! </details> <details> <summary>storybookjs/jest (@​storybook/jest)</summary> ### [`v0.2.1`](https://togithub.com/storybookjs/jest/releases/tag/v0.2.1) [Compare Source](https://togithub.com/storybookjs/jest/compare/v0.2.0...v0.2.1) ##### 🐛 Bug Fix - Release 0.2.1 [#​38](https://togithub.com/storybookjs/jest/pull/38) ([@​kasperpeulen](https://togithub.com/kasperpeulen)) - Specify triple slash reference in banner [#​37](https://togithub.com/storybookjs/jest/pull/37) ([@​kasperpeulen](https://togithub.com/kasperpeulen)) ##### Authors: 1 - Kasper Peulen ([@​kasperpeulen](https://togithub.com/kasperpeulen)) </details> <details> <summary>t3-oss/t3-env (@​t3-oss/env-nextjs)</summary> ### [`v0.6.1`](https://togithub.com/t3-oss/t3-env/blob/HEAD/packages/nextjs/CHANGELOG.md#061) [Compare Source](https://togithub.com/t3-oss/t3-env/compare/@t3-oss/[email protected]...@t3-oss/[email protected]) ##### Patch Changes - Updated dependencies \[[`6890765`](https://togithub.com/t3-oss/t3-env/commit/68907651b6a04dcc459cd21fda2edb20f018ea0f)]: - [@​t3-oss/env-core](https://togithub.com/t3-oss/env-core)[@​0](https://togithub.com/0).6.1 </details> <details> <summary>ueberdosis/tiptap (@​tiptap/extension-link)</summary> ### [`v2.1.3`](https://togithub.com/ueberdosis/tiptap/releases/tag/v2.1.3) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/v2.1.2...v2.1.3) #### What's Changed - fix autolink when code is not enabled for editor by [@​steven-qi](https://togithub.com/steven-qi) in [https://github.com/ueberdosis/tiptap/pull/4344](https://togithub.com/ueberdosis/tiptap/pull/4344) #### New Contributors - [@​steven-qi](https://togithub.com/steven-qi) made their first contribution in [https://github.com/ueberdosis/tiptap/pull/4344](https://togithub.com/ueberdosis/tiptap/pull/4344) **Full Changelog**: ueberdosis/tiptap@v2.1.2...v2.1.3 ### [`v2.1.2`](https://togithub.com/ueberdosis/tiptap/blob/HEAD/packages/extension-link/CHANGELOG.md#212-2023-08-17) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/v2.1.1...v2.1.2) **Note:** Version bump only for package [@​tiptap/extension-link](https://togithub.com/tiptap/extension-link) </details> <details> <summary>ueberdosis/tiptap (@​tiptap/starter-kit)</summary> ### [`v2.1.3`](https://togithub.com/ueberdosis/tiptap/compare/af017d18ade9fc741c37c325b187ae344daff040...c09d9e9e424d3206e56a35f66f9cf638e47efcd8) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/af017d18ade9fc741c37c325b187ae344daff040...c09d9e9e424d3206e56a35f66f9cf638e47efcd8) ### [`v2.1.2`](https://togithub.com/ueberdosis/tiptap/blob/HEAD/packages/starter-kit/CHANGELOG.md#212-2023-08-17) [Compare Source](https://togithub.com/ueberdosis/tiptap/compare/v2.1.1...v2.1.2) **Note:** Version bump only for package [@​tiptap/starter-kit](https://togithub.com/tiptap/starter-kit) </details> <details> <summary>KevinVandy/mantine-react-table (mantine-react-table)</summary> ### [`v1.1.2`](https://togithub.com/KevinVandy/mantine-react-table/releases/tag/v1.1.2) [Compare Source](https://togithub.com/KevinVandy/mantine-react-table/compare/v1.1.1...v1.1.2) #### What's Changed - Disable other row edit buttons when one row is being edited by default - Hide global and filter text input clear buttons until there is text in the input - Estonian (ET) locale with example by [@​madhenry](https://togithub.com/madhenry) in [https://github.com/KevinVandy/mantine-react-table/pull/110](https://togithub.com/KevinVandy/mantine-react-table/pull/110) #### New Contributors - [@​madhenry](https://togithub.com/madhenry) made their first contribution in [https://github.com/KevinVandy/mantine-react-table/pull/110](https://togithub.com/KevinVandy/mantine-react-table/pull/110) **Full Changelog**: KevinVandy/mantine-react-table@v1.1.1...v1.1.2 </details> <details> <summary>catamphetamine/react-phone-number-input (react-phone-number-input)</summary> ### [`v3.3.4`](https://gitlab.com/catamphetamine/react-phone-number-input/compare/v3.3.3...v3.3.4) [Compare Source](https://gitlab.com/catamphetamine/react-phone-number-input/compare/v3.3.3...v3.3.4) ### [`v3.3.3`](https://gitlab.com/catamphetamine/react-phone-number-input/compare/v3.3.2...v3.3.3) [Compare Source](https://gitlab.com/catamphetamine/react-phone-number-input/compare/v3.3.2...v3.3.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/InReach). PR-URL: #725 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
fix autolink issue when code extension is not enabled for the editor. See issue #4343 for more details
How did you accomplish your changes
There is a filter in the auto link handler to avoid auto link in a code block. However, when code is not enabled for a particular editor instance,
schema.marks.codewill beundefined. The handler passed it torangHasMarkswithout any validation, and cause an exception.To fix the issue, we can just return early from the handler when
schema.marks.codeis a falsy value.How have you tested your changes
Yes. As the code change is very small, I verified it by applying the same change to my local
node_modulesfolder.How can we verify your changes
To reproduce the issue, just setup an editor instance with
extension-linkincluded, but withoutextension-codeincluded, type a URL in the editor, then type a space, you should see an exception in the console, and link is not created.Note,
extension-codeis part ofStarterKit, that's why it does not happen for demos.After applying this change, auto-link should work without any console error, with or without
extension-codeRemarks
[add any additional remarks here]
Checklist
Related issues
#4343